MaxGekk commented on code in PR #44464:
URL: https://github.com/apache/spark/pull/44464#discussion_r1438075807
##########
connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala:
##########
@@ -230,55 +230,75 @@ private[client] object GrpcExceptionConverter {
params.cause)),
errorConstructor(params =>
new NoSuchTableException(params.errorClass.orNull,
params.messageParameters, params.cause)),
- errorConstructor[NumberFormatException](params =>
+ errorConstructor(params =>
new SparkNumberFormatException(
- params.message,
- params.errorClass,
+ params.errorClass.orNull,
params.messageParameters,
params.queryContext)),
+ errorConstructor[NumberFormatException](params =>
Review Comment:
Eventually, we should convert all Java exceptions to Spark exceptions but
since Spark SQL still raises such exceptions, different error class will allow
to identify which Java exceptions haven't been ported yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
