anishshri-db commented on code in PR #43961:
URL: https://github.com/apache/spark/pull/43961#discussion_r1440183858
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreSuite.scala:
##########
@@ -896,63 +918,69 @@ abstract class StateStoreSuiteBase[ProviderClass <:
StateStoreProvider]
protected val keySchema: StructType = StateStoreTestsHelper.keySchema
protected val valueSchema: StructType = StateStoreTestsHelper.valueSchema
- testWithAllCodec("get, put, remove, commit, and all data iterator") {
- tryWithProviderResource(newStoreProvider()) { provider =>
- // Verify state before starting a new set of updates
- assert(getLatestData(provider).isEmpty)
-
- val store = provider.getStore(0)
- assert(!store.hasCommitted)
- assert(get(store, "a", 0) === None)
- assert(store.iterator().isEmpty)
- assert(store.metrics.numKeys === 0)
-
- // Verify state after updating
- put(store, "a", 0, 1)
- assert(get(store, "a", 0) === Some(1))
-
- assert(store.iterator().nonEmpty)
- assert(getLatestData(provider).isEmpty)
-
- // Make updates, commit and then verify state
- put(store, "b", 0, 2)
- put(store, "aa", 0, 3)
- remove(store, _._1.startsWith("a"))
- assert(store.commit() === 1)
-
- assert(store.hasCommitted)
- assert(rowPairsToDataSet(store.iterator()) === Set(("b", 0) -> 2))
- assert(getLatestData(provider) === Set(("b", 0) -> 2))
-
- // Trying to get newer versions should fail
- var e = intercept[SparkException] {
- provider.getStore(2)
- }
- assert(e.getCause.isInstanceOf[SparkException])
- assert(e.getCause.getMessage.contains("does not exist"))
-
- e = intercept[SparkException] {
- getData(provider, 2)
- }
- assert(e.getCause.isInstanceOf[SparkException])
- assert(e.getCause.getMessage.contains("does not exist"))
+ Seq(true, false).foreach { useColumnFamilies =>
Review Comment:
Updated
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala:
##########
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.streaming
+
+import org.apache.spark.SparkException
+import org.apache.spark.internal.Logging
+import org.apache.spark.sql.{AnalysisException, SaveMode}
+import org.apache.spark.sql.execution.streaming._
+import
org.apache.spark.sql.execution.streaming.state.{AlsoTestWithChangelogCheckpointingEnabled,
RocksDBStateStoreProvider}
+import org.apache.spark.sql.internal.SQLConf
+
+class RunningCountStatefulProcessor extends StatefulProcessor[String, String,
(String, String)]
+ with Logging {
+ @transient private var _countState: ValueState[Long] = _
+ @transient var _processorHandle: StatefulProcessorHandle = _
+
+ override def init(handle: StatefulProcessorHandle,
+ outputMode: OutputMode) : Unit = {
+ _processorHandle = handle
+ assert(handle.getQueryInfo().getBatchId >= 0)
+ assert(handle.getQueryInfo().getOperatorId == 0)
+ assert(handle.getQueryInfo().getPartitionId >= 0 &&
handle.getQueryInfo().getPartitionId < 5)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
