andylam-db commented on PR #44084: URL: https://github.com/apache/spark/pull/44084#issuecomment-1876106530
> We are already doing it to run tests for JDBC data sources @cloud-fan I didn't know about those tests! I made the changes to add this as an integration test instead, as you suggested. The two tests are a bit disconnected: 1. It's maybe a bit weird that a test in `spark/connector` uses files in `spark/core`, but this can be improved in the future. 2. There's some code duplication to read golden files, but I think not too much that it is bad code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
