dongjoon-hyun commented on code in PR #44582: URL: https://github.com/apache/spark/pull/44582#discussion_r1441081593
########## sql/core/benchmarks/BloomFilterBenchmark-jdk21-results.txt: ########## @@ -2,191 +2,191 @@ ORC Write ================================================================================================ -OpenJDK 64-Bit Server VM 21+35 on Linux 5.15.0-1046-azure -Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz +OpenJDK 64-Bit Server VM 21.0.1+12-LTS on Linux 5.15.0-1053-azure +AMD EPYC 7763 64-Core Processor Write 100M rows: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ -Without bloom filter 11165 11186 30 9.0 111.6 1.0X -With bloom filter 14006 14047 58 7.1 140.1 0.8X +Without bloom filter 7394 7604 297 13.5 73.9 1.0X +With bloom filter 9697 9733 51 10.3 97.0 0.8X ================================================================================================ ORC Read ================================================================================================ -OpenJDK 64-Bit Server VM 21+35 on Linux 5.15.0-1046-azure -Intel(R) Xeon(R) Platinum 8370C CPU @ 2.80GHz +OpenJDK 64-Bit Server VM 21.0.1+12-LTS on Linux 5.15.0-1053-azure +AMD EPYC 7763 64-Core Processor Read a row from 100M rows: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ -Without bloom filter, blocksize: 2097152 1291 1323 45 77.4 12.9 1.0X -With bloom filter, blocksize: 2097152 1065 1079 20 93.9 10.6 1.2X +Without bloom filter, blocksize: 2097152 869 901 52 115.1 8.7 1.0X +With bloom filter, blocksize: 2097152 890 895 7 112.4 8.9 1.0X Review Comment: ~This could be a regression. Let me take a look.~ The other bloomfilter read benchmarks (including Java 17) look good. This seems to be a transient issue due to the GitHub Action at that runtime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
