Github user harishreedharan commented on a diff in the pull request:
https://github.com/apache/spark/pull/5792#discussion_r31171136
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -219,6 +220,19 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
}
}
+ override def getEventLogPaths(appId: String, attemptId: Option[String]):
Seq[Path] = {
+
+ val filePaths = new ArrayBuffer[Path]()
+ applications.get(appId).foreach { appInfo =>
--- End diff --
The reason I left `attempt.attemptId.isEmpty` here is so that even if
someone makes a bad request asking for logs for an attempt which has no
`attemptId`, we still download all logs. I know it is a bad request, but it is
easy to handle. Also, I am not sure how `==` works for an `Option`, so this
ensure that an exception does not get thrown in the `get` calls at the end of
the line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
