zhengruifeng commented on code in PR #44611:
URL: https://github.com/apache/spark/pull/44611#discussion_r1442768884
##########
python/pyspark/pandas/tests/connect/groupby/test_parity_grouping.py:
##########
@@ -19,10 +19,14 @@
from pyspark.pandas.tests.groupby.test_grouping import GroupingTestsMixin
from pyspark.testing.connectutils import ReusedConnectTestCase
-from pyspark.testing.pandasutils import PandasOnSparkTestCase
+from pyspark.testing.pandasutils import PandasOnSparkTestUtils
Review Comment:
manually check that, before this fix this test suite fails with
```
test_getitem
(pyspark.pandas.tests.connect.groupby.test_parity_grouping.GroupingParityTests.test_getitem)
... ok (0.022s)
test_assert_vanilla_mode
(pyspark.testing.pandasutils.PandasOnSparkTestCase.test_assert_vanilla_mode)
... ok (0.000s)
test_assert_remote_mode
(pyspark.testing.connectutils.ReusedConnectTestCase.test_assert_remote_mode)
... ok (0.000s)
======================================================================
FAIL [0.003s]: test_assert_remote_mode
(pyspark.pandas.tests.connect.groupby.test_parity_grouping.GroupingParityTests.test_assert_remote_mode)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/ruifeng.zheng/Dev/spark/python/pyspark/testing/connectutils.py", line
199, in test_assert_remote_mode
self.assertTrue(is_remote())
AssertionError: False is not true
----------------------------------------------------------------------
Ran 6 tests in 8.455s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
