cloud-fan commented on code in PR #44602:
URL: https://github.com/apache/spark/pull/44602#discussion_r1443129337
##########
sql/api/src/main/scala/org/apache/spark/sql/internal/SqlApiConf.scala:
##########
@@ -48,23 +47,16 @@ private[sql] trait SqlApiConf {
private[sql] object SqlApiConf {
// Shared keys.
- val ANSI_ENABLED_KEY: String = "spark.sql.ansi.enabled"
- val LEGACY_TIME_PARSER_POLICY_KEY: String =
"spark.sql.legacy.timeParserPolicy"
- val CASE_SENSITIVE_KEY: String = "spark.sql.caseSensitive"
- val SESSION_LOCAL_TIMEZONE_KEY: String = "spark.sql.session.timeZone"
- val LOCAL_RELATION_CACHE_THRESHOLD_KEY: String =
"spark.sql.session.localRelationCacheThreshold"
-
+ val ANSI_ENABLED_KEY: String = SqlApiConfHelper.ANSI_ENABLED_KEY
+ val LEGACY_TIME_PARSER_POLICY_KEY: String =
SqlApiConfHelper.LEGACY_TIME_PARSER_POLICY_KEY
+ val CASE_SENSITIVE_KEY: String = SqlApiConfHelper.CASE_SENSITIVE_KEY
+ val SESSION_LOCAL_TIMEZONE_KEY: String =
SqlApiConfHelper.SESSION_LOCAL_TIMEZONE_KEY
+ val LOCAL_RELATION_CACHE_THRESHOLD_KEY: String =
+ SqlApiConfHelper.LOCAL_RELATION_CACHE_THRESHOLD_KEY
/**
* Defines a getter that returns the [[SqlApiConf]] within scope.
*/
- private val confGetter = new AtomicReference[() => SqlApiConf](() =>
DefaultSqlApiConf)
-
- /**
- * Sets the active config getter.
- */
- private[sql] def setConfGetter(getter: () => SqlApiConf): Unit = {
- confGetter.set(getter)
- }
+ private val confGetter = SqlApiConfHelper.getConfGetter
Review Comment:
do we need this val? `def get: SqlApiConf =
SqlApiConfHelper.getConfGetter.get()()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
