cloud-fan commented on code in PR #44513:
URL: https://github.com/apache/spark/pull/44513#discussion_r1444301267
##########
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/ParquetVectorUpdaterFactory.java:
##########
@@ -1418,16 +1610,21 @@ private SchemaColumnConvertNotSupportedException
constructConvertNotSupportedExc
private static boolean canReadAsIntDecimal(ColumnDescriptor descriptor,
DataType dt) {
if (!DecimalType.is32BitDecimalType(dt)) return false;
- return isDecimalTypeMatched(descriptor, dt);
+ return isDecimalTypeMatched(descriptor, dt) &&
isSameDecimalScale(descriptor, dt);
Review Comment:
is this extra restriction a bug fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
