nchammas commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1445378532
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,125 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
Review Comment:
> I think we can just revive the `if`s there, and I think we can just go
ahead and merge. Let me reopen this PR.
@HyukjinKwon - Actually, thinking about this a bit more , is this really the
behavior we want to have?
It's technically a type of silent failure if Jekyll successfully builds our
docs but can't find some file that was referenced via `include` or
`include_relative`. The way `docs/sql-ref-functions-builtin.md` is currently
setup makes it so that Jekyll will never detect these missing includes.
Isn't that actually a bad thing? Using this pattern, how will developers
know that the documentation built correctly without manually reviewing _every_
rendered site where they wrote a conditional include?
It seems like we need a way to ignore missing includes only when
`SKIP_API=1`. Do you agree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
