cloud-fan commented on code in PR #44397:
URL: https://github.com/apache/spark/pull/44397#discussion_r1445973126
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/aggregate/GeneralAggregateFunc.java:
##########
@@ -51,11 +53,21 @@ public final class GeneralAggregateFunc extends
ExpressionWithToString implement
private final String name;
private final boolean isDistinct;
private final Expression[] children;
+ private final Expression[] orderingWithinGroups;
Review Comment:
shall we use `SortOrder[]`?
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/expressions/aggregate/GeneralAggregateFunc.java:
##########
@@ -64,6 +76,8 @@ public GeneralAggregateFunc(String name, boolean isDistinct,
Expression[] childr
@Override
public Expression[] children() { return children; }
+ public Expression[] orderingWithinGroups() { return orderingWithinGroups; }
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
