mridulm commented on code in PR #44673:
URL: https://github.com/apache/spark/pull/44673#discussion_r1448062743
##########
core/src/main/scala/org/apache/spark/deploy/master/Master.scala:
##########
@@ -619,6 +619,9 @@ private[deploy] class Master(
case e: Exception => logInfo("Worker " + worker.id + " had exception
on reconnect")
}
}
+
+ // In case of zero workers and apps, we can complete recovery.
+ if (canCompleteRecovery) { completeRecovery() }
Review Comment:
super nit:
```suggestion
if (canCompleteRecovery) {
completeRecovery()
}
```
Not sure why this is the style in rest of the class though :-(
##########
core/src/main/scala/org/apache/spark/deploy/master/Master.scala:
##########
@@ -619,6 +619,9 @@ private[deploy] class Master(
case e: Exception => logInfo("Worker " + worker.id + " had exception
on reconnect")
}
}
+
+ // In case of zero workers and apps, we can complete recovery.
+ if (canCompleteRecovery) { completeRecovery() }
}
Review Comment:
If we are completing recovery when `canCompleteRecovery == true`, we can
avoid scheduling `CompleteRecovery` task ?
Perhaps returns a `boolean` from this method to indicate it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
