dongjoon-hyun commented on code in PR #44636:
URL: https://github.com/apache/spark/pull/44636#discussion_r1448101682
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala:
##########
@@ -1153,174 +1153,213 @@ class FileStreamSourceSuite extends
FileStreamSourceTest {
}
}
- test("max files per trigger") {
- withTempDir { case src =>
- var lastFileModTime: Option[Long] = None
+ test("maxFilesPerTrigger & maxBytesPerTrigger threshold logic must be
obeyed") {
Review Comment:
Please don't touch the existing old test case. Since we don't allow both
threshold. The should be independently tested. The code duplication can be
refactored into a test helper method instead of making a big single test case.
Also, please use the test prefix like the following.
```scala
- test("maxFilesPerTrigger & maxBytesPerTrigger threshold logic must be
obeyed") {
+ test("SPARK-46641: maxBytesPerTrigger threshold logic must be obeyed") {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
