vicennial commented on code in PR #44670:
URL: https://github.com/apache/spark/pull/44670#discussion_r1448778094


##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectReattachExecuteHandler.scala:
##########
@@ -29,25 +29,26 @@ class SparkConnectReattachExecuteHandler(
     extends Logging {
 
   def handle(v: proto.ReattachExecuteRequest): Unit = {
-    val executeHolder = SparkConnectService.executionManager
-      .getExecuteHolder(ExecuteKey(v.getUserContext.getUserId, v.getSessionId, 
v.getOperationId))

Review Comment:
   Hmm, interestingly the python client tests are failing in `ReleaseExecute` 
https://github.com/vicennial/spark/actions/runs/7486495590/job/20377029638 
   ```
   /__w/spark/spark/python/pyspark/sql/connect/client/reattach.py:231: 
UserWarning: ReleaseExecute failed with exception: <_InactiveRpcError of RPC 
that terminated with:
        status = StatusCode.INTERNAL
        details = "[INVALID_HANDLE.SESSION_CLOSED] The handle 
da42ad8c-12d3-476f-8240-0ed36d34ebe4 is invalid. Session was closed. SQLSTATE: 
HY000"
        debug_error_string = "UNKNOWN:Error received from peer  
{created_time:"2024-01-11T09:25:48.603606747+00:00", grpc_status:13, 
grpc_message:"[INVALID_HANDLE.SESSION_CLOSED] The handle 
da42ad8c-12d3-476f-8240-0ed36d34ebe4 is invalid. Session was closed. SQLSTATE: 
HY000"}"
   >.
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to