lyy-pineapple commented on PR #44705: URL: https://github.com/apache/spark/pull/44705#issuecomment-1891185867
> Can you add a test to ensure this does not recur in future ? +CC @tgravescs > Can you add a test to ensure this does not recur in future ? +CC @tgravescs Adding tests can be challenging because all processes are within the initialization. To avoid this issue, we can add `assert(master != null)` in the function. Alternatively, consider changing the following variables to `lazy val `to ensure they are initialized before usage.I have chosen to include an assert statement here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
