cashmand opened a new pull request, #44742:
URL: https://github.com/apache/spark/pull/44742
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR:
https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a
faster review.
7. If you want to add a new configuration, please read the guideline first
for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the
guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Follow-up to https://github.com/apache/spark/pull/43984: we should not allow
partitioning on VariantType. Even though it is is an atomic type, it represents
a nested semi-structured value, so not partitioning is consistent with our
decision to not allow partitioning on nested types. Also, for now at least, it
is not even comparable, so attempting to partition fails with a confusing
codegen error about a method named `compare` not being declared.
### Why are the changes needed?
Improves error message when attempting to partition on Variant, and
explicitly forbids a case that we do not intend to support.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Added unit test, which fails without the code change.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
