nchammas commented on code in PR #44754:
URL: https://github.com/apache/spark/pull/44754#discussion_r1453598396
##########
.github/workflows/build_and_test.yml:
##########
@@ -751,13 +752,16 @@ jobs:
Rscript -e "install.packages(c('devtools', 'testthat', 'knitr',
'rmarkdown', 'markdown', 'e1071', 'roxygen2', 'ggplot2', 'mvtnorm', 'statmod'),
repos='https://cloud.r-project.org/')"
Rscript -e "devtools::install_version('pkgdown', version='2.0.1',
repos='https://cloud.r-project.org')"
Rscript -e "devtools::install_version('preferably', version='0.4',
repos='https://cloud.r-project.org')"
+ # Should merge this step with 'Install Python linter dependencies' after
SPARK 3.5 EOL.
Review Comment:
Why not merge all these requirements into the existing
`dev/requirements.txt`?
##########
.github/workflows/build_and_test.yml:
##########
@@ -702,8 +702,9 @@ jobs:
- name: Install Python linter dependencies
if: inputs.branch != 'branch-3.4' && inputs.branch != 'branch-3.5'
run: |
- python3.9 -m pip install 'flake8==3.9.0' pydata_sphinx_theme
'mypy==0.982' 'pytest==7.1.3' 'pytest-mypy-plugins==1.9.3' numpydoc jinja2
'black==23.9.1'
- python3.9 -m pip install 'pandas-stubs==1.2.0.53' ipython
'grpcio==1.59.3' 'grpc-stubs==1.24.11' 'googleapis-common-protos-stubs==2.2.0'
+ python3.9 -m pip install 'flake8==3.9.0' pydata_sphinx_theme
'mypy==0.982' 'pytest==7.1.3' 'pytest-mypy-plugins==1.9.3' numpydoc jinja2
'black==23.9.1' \
Review Comment:
Maybe the subject for a separate PR, but is `pydata_sphinx_theme` truly a
dependency for the Python linter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
