vitaliili-db commented on code in PR #44644:
URL: https://github.com/apache/spark/pull/44644#discussion_r1454047848
##########
connector/protobuf/src/test/scala/org/apache/spark/sql/protobuf/ProtobufSerdeSuite.scala:
##########
@@ -126,14 +122,6 @@ class ProtobufSerdeSuite extends SharedSparkSession with
ProtobufTestBase {
params = Map(
"protobufType" -> "FieldMissingInProto",
"toType" -> toSQLType(CATALYST_STRUCT)))
-
- assertFailedConversionMessage(protoFile,
Review Comment:
This test variation does not make sense since `nonnullCatalyst.toSql`
produces different result from `CATALYST_STRUCT.toSql`. Missing non-nullable
field is tested in "Fail to convert with missing Catalyst fields"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
