dongjoon-hyun commented on PR #44761: URL: https://github.com/apache/spark/pull/44761#issuecomment-1894915741
To @MaxGekk and @HyukjinKwon . At my previous comment, I was confused because [Hive's CompressionKind is behind](https://github.com/apache/hive/blob/3ef1c3a0743b9538d09cd9307250150a21fc8537/ql/src/java/org/apache/hadoop/hive/ql/io/orc/CompressionKind.java#L27-L30). Here, I double-check the following in Spark codebase and make a PR, #44765 , to make it sure. In short, For the following question, yes, `hive` module's `OrcFileFormat` is switched to ZStandard together. > Just in case, the benchmark belongs to hive (at least it is in sql/hive). Which codec does hive use, and has it switched to zstandard already? - `sql` module's - `OrcFileFormat`: https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala - `hive` module's - `OrcFileFormat`: https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
