LuciferYang commented on PR #44732: URL: https://github.com/apache/spark/pull/44732#issuecomment-1894984377
This change of this pr is fine to me. However, I would like to raise a question: Would it be simpler and clearer to implement the logic for cleaning up the `DownloadFile` resource using the `java.lang.ref.Cleaner` mechanism instead of the current approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
