cloud-fan commented on code in PR #44789:
URL: https://github.com/apache/spark/pull/44789#discussion_r1458648993
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/csv/CSVInferSchemaSuite.scala:
##########
@@ -267,7 +267,9 @@ class CSVInferSchemaSuite extends SparkFunSuite with
SQLHelper {
test("SPARK-45433: inferring the schema when timestamps do not match
specified timestampFormat" +
" with only one row") {
val options = new CSVOptions(
- Map("timestampFormat" -> "yyyy-MM-dd'T'HH:mm:ss"),
+ Map(
+ "timestampFormat" -> "yyyy-MM-dd'T'HH:mm:ss",
+ "timestampNTZFormat" -> "yyyy-MM-dd HH:mm:ss"),
Review Comment:
I don't agree. A query fails if an option is not set is not really a good
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
