itholic commented on code in PR #44848:
URL: https://github.com/apache/spark/pull/44848#discussion_r1462697579
##########
python/pyspark/sql/dataframe.py:
##########
@@ -1319,6 +1319,7 @@ def hint(
error_class="DISALLOWED_TYPE_FOR_CONTAINER",
message_parameters={
"arg_name": "parameters",
+ "arg_type": type(parameters).__name__,
Review Comment:
Hmm... this also seems to be problematic. It seems that an error should have
occurred if a parameter defined in the template was actually missing. Let me
investigate this too.
##########
python/pyspark/errors/error_classes.py:
##########
@@ -253,58 +258,58 @@
"<right_dtype>"
]
},
- "DIFFERENT_ROWS" : {
- "message" : [
+ "DIFFERENT_ROWS": {
+ "message": [
"<error_msg>"
]
},
- "DIFFERENT_SCHEMA" : {
- "message" : [
+ "DIFFERENT_SCHEMA": {
+ "message": [
"Schemas do not match.",
"--- actual",
"+++ expected",
"<error_msg>"
]
},
- "DISALLOWED_TYPE_FOR_CONTAINER" : {
- "message" : [
- "Argument `<arg_name>`(type: <arg_type>) should only contain a type in
[<allowed_types>], got <return_type>"
+ "DISALLOWED_TYPE_FOR_CONTAINER": {
+ "message": [
+ "Argument `<arg_name>`(type: <arg_type>) should only contain a type in
[<allowed_types>], got <item_type>"
Review Comment:
Oh... does it mean that the parameter name was not matched between template
and actual usage but didn't raise any error so far? Let me investigate and
create a ticket for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
