itholic commented on code in PR #44778:
URL: https://github.com/apache/spark/pull/44778#discussion_r1464198106
##########
python/pyspark/sql/tests/test_utils.py:
##########
@@ -45,9 +45,14 @@
IntegerType,
BooleanType,
)
-from pyspark.testing.sqlutils import have_pandas
+from pyspark.testing.sqlutils import (
+ have_pandas,
+ have_pyarrow,
+ pyarrow_requirement_message,
+)
[email protected](not have_pyarrow, pyarrow_requirement_message)
class UtilsTestsMixin:
Review Comment:
Hmm,, I don't think `assertDataFrameEqual` uses `pyarrow`?? It uses
`pandas`, but it's not required package because we just skip using pandas when
it's not installed. Could check
[comment](https://github.com/apache/spark/pull/44778#discussion_r1464195098)
above?
##########
python/pyspark/sql/tests/test_utils.py:
##########
@@ -45,9 +45,14 @@
IntegerType,
BooleanType,
)
-from pyspark.testing.sqlutils import have_pandas
+from pyspark.testing.sqlutils import (
+ have_pandas,
+ have_pyarrow,
+ pyarrow_requirement_message,
+)
[email protected](not have_pyarrow, pyarrow_requirement_message)
class UtilsTestsMixin:
Review Comment:
Hmm,, I don't think `assertDataFrameEqual` uses `pyarrow`?? It uses `pandas`
instead, but it's not required package because we just skip using pandas when
it's not installed. Could check
[comment](https://github.com/apache/spark/pull/44778#discussion_r1464195098)
above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
