LuciferYang commented on code in PR #44866:
URL: https://github.com/apache/spark/pull/44866#discussion_r1464540618
##########
.github/workflows/build_and_test.yml:
##########
@@ -687,14 +687,14 @@ jobs:
# SPARK-44554: Copy from
https://github.com/apache/spark/blob/a05c27e85829fe742c1828507a1fd180cdc84b54/.github/workflows/build_and_test.yml#L571-L578
# Should delete this section after SPARK 3.4 EOL.
python3.9 -m pip install 'flake8==3.9.0' pydata_sphinx_theme
'mypy==0.920' 'pytest==7.1.3' 'pytest-mypy-plugins==1.9.3' numpydoc
'jinja2<3.0.0' 'black==22.6.0'
- python3.9 -m pip install 'pandas-stubs==1.2.0.53' ipython
'grpcio==1.59.3' 'grpc-stubs==1.24.11' 'googleapis-common-protos-stubs==2.2.0'
+ python3.9 -m pip install 'pandas-stubs==1.2.0.53' ipython
'grpcio==1.48.1' 'grpc-stubs==1.24.11' 'googleapis-common-protos-stubs==2.2.0'
Review Comment:
The names of these two steps are `Install Python linter dependencies for
branch-3.4` and `Install Python linter dependencies for branch-3.5`. When I
added them, it was to fix the dependency conflicts during the daily test of
`branch-3.4/3.5`. If the versions of the dependencies in the `Install Python
linter dependencies` step have not been upgraded in `branch-3.4/branch-3.5`, I
personally believe that the versions of these two steps should not be changed.
They will not affect the build of the master itself.
##########
.github/workflows/build_and_test.yml:
##########
@@ -687,14 +687,14 @@ jobs:
# SPARK-44554: Copy from
https://github.com/apache/spark/blob/a05c27e85829fe742c1828507a1fd180cdc84b54/.github/workflows/build_and_test.yml#L571-L578
# Should delete this section after SPARK 3.4 EOL.
python3.9 -m pip install 'flake8==3.9.0' pydata_sphinx_theme
'mypy==0.920' 'pytest==7.1.3' 'pytest-mypy-plugins==1.9.3' numpydoc
'jinja2<3.0.0' 'black==22.6.0'
- python3.9 -m pip install 'pandas-stubs==1.2.0.53' ipython
'grpcio==1.59.3' 'grpc-stubs==1.24.11' 'googleapis-common-protos-stubs==2.2.0'
+ python3.9 -m pip install 'pandas-stubs==1.2.0.53' ipython
'grpcio==1.48.1' 'grpc-stubs==1.24.11' 'googleapis-common-protos-stubs==2.2.0'
Review Comment:
The names of these two steps are `Install Python linter dependencies for
branch-3.4` and `Install Python linter dependencies for branch-3.5`. When I
added them, it was to fix the dependency conflicts during the daily test of
`branch-3.4/3.5`. If the versions of the dependencies in the `Install Python
linter dependencies` step have not been upgraded in `branch-3.4/branch-3.5`, I
personally think that the versions of these two steps should not be changed.
They will not affect the build of the master itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
