panbingkun commented on code in PR #44871:
URL: https://github.com/apache/spark/pull/44871#discussion_r1465786661
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityParser.scala:
##########
@@ -273,8 +272,7 @@ class UnivocityParser(
case udt: UserDefinedType[_] =>
makeConverter(name, udt.sqlType, nullable)
- // We don't actually hit this exception though, we keep it for
understandability
- case _ => throw QueryExecutionErrors.unsupportedTypeError(dataType)
Review Comment:
This exception can be triggered from the `user's perspective`, so I suggest
removing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]