LuciferYang commented on code in PR #44877:
URL: https://github.com/apache/spark/pull/44877#discussion_r1465803239
##########
.github/workflows/build_and_test.yml:
##########
@@ -714,7 +714,7 @@ jobs:
if: inputs.branch == 'branch-3.5'
run: |
# See more in "Installation"
https://docs.buf.build/installation#tarball
- curl -LO
https://github.com/bufbuild/buf/releases/download/v1.28.1/buf-Linux-x86_64.tar.gz
+ curl -LO
https://github.com/bufbuild/buf/releases/download/v1.29.0/buf-Linux-x86_64.tar.gz
Review Comment:
I think there are only two situations where we need to change the parts
specially defined for `branch-3.4/branch-3.5` in `build_and_test.yml`:
1. The daily test of `branch-3.4/branch-3.5` fails, and changes cannot be
avoided.
2. `branch-3.4/branch-3.5` has changed, and these changes need to be
synchronized to `build_and_test.yml` to ensure that the daily test uses the
same dependencies.
In other cases, I think they should be left as they are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
