HeartSaVioR commented on code in PR #44712:
URL: https://github.com/apache/spark/pull/44712#discussion_r1465823018
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala:
##########
@@ -671,6 +682,21 @@ class RocksDB(
override protected def logName: String = s"${super.logName} $loggingId"
}
+object RocksDB {
Review Comment:
We are not saying it will be called multiple times. We meant it is not clear
whether this block is ever evaluated (executed once) or not (never executed),
because we do not explicitly refer this object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]