MaxGekk commented on code in PR #44863:
URL: https://github.com/apache/spark/pull/44863#discussion_r1466581920
##########
common/utils/src/main/scala/org/apache/spark/ErrorClassesJSONReader.scala:
##########
@@ -153,3 +153,14 @@ private case class ErrorSubInfo(message: Seq[String]) {
@JsonIgnore
val messageTemplate: String = message.mkString("\n")
}
+
+/**
+ * Information associated with an error state / SQLSTATE.
+ *
+ * @param description
+ * @param origin The database system where this error state was first defined.
Review Comment:
Precisely, `database system` -> DBMS
##########
common/utils/src/main/scala/org/apache/spark/ErrorClassesJSONReader.scala:
##########
@@ -153,3 +153,14 @@ private case class ErrorSubInfo(message: Seq[String]) {
@JsonIgnore
val messageTemplate: String = message.mkString("\n")
}
+
+/**
+ * Information associated with an error state / SQLSTATE.
+ *
+ * @param description
Review Comment:
Add a sentence about the parameter.
##########
common/utils/src/main/scala/org/apache/spark/ErrorClassesJSONReader.scala:
##########
@@ -153,3 +153,14 @@ private case class ErrorSubInfo(message: Seq[String]) {
@JsonIgnore
val messageTemplate: String = message.mkString("\n")
}
+
+/**
+ * Information associated with an error state / SQLSTATE.
+ *
+ * @param description
+ * @param origin The database system where this error state was first defined.
+ * @param standard Whether this error state is part of the SQL standard.
+ * @param usedBy What database systems use this error state.
+ */
+private case class ErrorStateInfo(
+ description: String, origin: String, standard: String, usedBy: List[String])
Review Comment:
Please, fix indentation, see
https://github.com/databricks/scala-style-guide?tab=readme-ov-file#indent
```suggestion
description: String,
origin: String,
standard: String,
usedBy: List[String])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
