dongjoon-hyun commented on code in PR #44882:
URL: https://github.com/apache/spark/pull/44882#discussion_r1466635715
##########
core/src/main/scala/org/apache/spark/rdd/RDD.scala:
##########
@@ -224,14 +224,17 @@ abstract class RDD[T: ClassTag](
* not use `this` because RDDs are user-visible, so users might have added
their own locking on
* RDDs; sharing that could lead to a deadlock.
*
- * One thread might hold the lock on many of these, for a chain of RDD
dependencies; but
- * because DAGs are acyclic, and we only ever hold locks for one path in
that DAG, there is no
- * chance of deadlock.
+ * One thread might hold the lock on many of these, for a chain of RDD
dependencies. Deadlocks
+ * are possible if we try to lock another resource while holding the
stateLock,
+ * and the lock acquisition sequence of these locks is not guaranteed to be
the same.
+ * This can lead lead to a deadlock as one thread might first acquire the
stateLock,
Review Comment:
nit. `lead lead` -> `lead`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
