dongjoon-hyun commented on code in PR #44876:
URL: https://github.com/apache/spark/pull/44876#discussion_r1466937063
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala:
##########
@@ -456,13 +456,16 @@ trait V2CreateTablePlan extends LogicalPlan {
/**
* Create a new table with a v2 catalog.
+ * The [[defaults]] hold optional default value expressions to use when
creating the table,
+ * mapping 1:1 with the fields in [[tableSchema]].
*/
case class CreateTable(
name: LogicalPlan,
tableSchema: StructType,
partitioning: Seq[Transform],
tableSpec: TableSpecBase,
- ignoreIfExists: Boolean)
+ ignoreIfExists: Boolean,
+ defaults: Seq[Option[Expression]])
Review Comment:
Could you rename `defaults` to `defaultValues` or `defaultValueExpressions`
here? `default` looks a little too broad in the context of `Table` definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
