anishshri-db commented on code in PR #44903:
URL: https://github.com/apache/spark/pull/44903#discussion_r1468231575
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala:
##########
@@ -201,6 +201,11 @@ private[sql] class HDFSBackedStateStoreProvider extends
StateStoreProvider with
override def toString(): String = {
s"HDFSStateStore[id=(op=${id.operatorId},part=${id.partitionId}),dir=$baseDir]"
}
+
+ override def removeColFamilyIfExists(colFamilyName: String): Unit = {
+ throw new UnsupportedOperationException("Removing multiple column
families with " +
Review Comment:
Nit: `Removing column family with`
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -189,6 +189,11 @@ private[sql] class RocksDBStateStoreProvider
/** Return the [[RocksDB]] instance in this store. This is exposed mainly
for testing. */
def dbInstance(): RocksDB = rocksDB
+
+ /** Remove column family if exists */
+ override def removeColFamilyIfExists(colFamilyName: String): Unit = {
+ rocksDB.removeColFamilyIfExists(colFamilyName)
Review Comment:
nit: indent ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
