dongjoon-hyun opened a new pull request, #44916:
URL: https://github.com/apache/spark/pull/44916

   ### What changes were proposed in this pull request?
   
   This PR aims to add `checkValues` to 
`spark.master.ui.decommission.allow.mode` configuration to validate the setting 
as early as possible.
   
   ### Why are the changes needed?
   
   To prevent misconfigurations.
   
   **BEFORE (NO WARNING)**
   ```
   $ SPARK_NO_DAEMONIZE=1 
SPARK_MASTER_OPTS="-Dspark.master.ui.decommission.allow.mode=ALLOWS" 
sbin/start-master.sh
   ...
   24/01/27 22:14:25 INFO Master: I have been elected leader! New state: ALIVE
   ```
   
   **AFTER (FAILURE)**
   ```
   $ SPARK_NO_DAEMONIZE=1 
SPARK_MASTER_OPTS="-Dspark.master.ui.decommission.allow.mode=ALLOWS" 
sbin/start-master.sh
   ...
   java.lang.IllegalArgumentException: The value of 
spark.master.ui.decommission.allow.mode should be one of ALLOW, LOCAL, DENY, 
but was ALLOWS
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes However, this prevents a user to start `Spark Master` with 
misconfiguration. So, it happens only at the first start of the migrated Spark 
master installation. So, this is going to be solved before running Spark Master 
successfully first time.
   
   ### How was this patch tested?
   
   Manually.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to