HyukjinKwon commented on code in PR #44897:
URL: https://github.com/apache/spark/pull/44897#discussion_r1469138830
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSet.scala:
##########
@@ -168,8 +170,8 @@ class ExpressionSet protected(
override def clone(): ExpressionSet = new ExpressionSet(baseSet.clone(),
originals.clone())
/**
- * Returns a string containing both the post [[Canonicalize]] expressions
and the original
- * expressions in this set.
+ * Returns a string containing both the post [[Expression.canonicalized]]
expressions
Review Comment:
```suggestion
* Returns a string containing both the post [[Expression#canonicalized]]
expressions
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSet.scala:
##########
@@ -36,7 +38,7 @@ object ExpressionSet {
/**
* A [[Set]] where membership is determined based on determinacy and a
canonical representation of
* an [[Expression]] (i.e. one that attempts to ignore cosmetic differences).
- * See [[Canonicalize]] for more details.
+ * See [[Expression.canonicalized]] for more details.
Review Comment:
```suggestion
* See [[Expression#canonicalized]] for more details.
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala:
##########
@@ -311,7 +311,7 @@ abstract class Expression extends TreeNode[Expression] {
* Returns true when two expressions will always compute the same result,
even if they differ
* cosmetically (i.e. capitalization of names in attributes may be
different).
*
- * See [[Canonicalize]] for more details.
+ * See [[Expression.canonicalized]] for more details.
Review Comment:
```suggestion
* See [[Expression#canonicalized]] for more details.
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala:
##########
@@ -320,7 +320,7 @@ abstract class Expression extends TreeNode[Expression] {
* Returns a `hashCode` for the calculation performed by this expression.
Unlike the standard
* `hashCode`, an attempt has been made to eliminate cosmetic differences.
*
- * See [[Canonicalize]] for more details.
+ * See [[Expression.canonicalized]] for more details.
Review Comment:
```suggestion
* See [[Expression#canonicalized]] for more details.
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/QueryPlanConstraints.scala:
##########
@@ -48,7 +48,7 @@ trait QueryPlanConstraints extends ConstraintHelper { self:
LogicalPlan =>
* canonicalized and filtered automatically to contain only those attributes
that appear in the
* [[outputSet]].
*
- * See [[Canonicalize]] for more details.
+ * See [[Expression.canonicalized]] for more details.
Review Comment:
```suggestion
* See [[Expression#canonicalized]] for more details.
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ExpressionSet.scala:
##########
@@ -21,7 +21,9 @@ import scala.collection.mutable
import scala.collection.mutable.ArrayBuffer
object ExpressionSet {
- /** Constructs a new [[ExpressionSet]] by applying [[Canonicalize]] to
`expressions`. */
+ /**
+ * Constructs a new [[ExpressionSet]] by applying
[[Expression.canonicalized]] to `expressions`.
Review Comment:
```suggestion
* Constructs a new [[ExpressionSet]] by applying
[[Expression#canonicalized]] to `expressions`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
