beliefer commented on code in PR #44892:
URL: https://github.com/apache/spark/pull/44892#discussion_r1469484842
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala:
##########
@@ -138,7 +138,7 @@ class CatalogManager(
}
def listCatalogs(pattern: Option[String]): Seq[String] = {
- val allCatalogs = (synchronized(catalogs.keys.toSeq) :+
SESSION_CATALOG_NAME).distinct.sorted
+ val allCatalogs = (catalogs.keys.toSeq :+
SESSION_CATALOG_NAME).distinct.sorted
Review Comment:
We should use
synchronized(catalogs) {
catalogs.keys.toSeq
}
if the accesses of catalogs should be synchronized.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/CatalogManager.scala:
##########
@@ -138,7 +138,7 @@ class CatalogManager(
}
def listCatalogs(pattern: Option[String]): Seq[String] = {
- val allCatalogs = (synchronized(catalogs.keys.toSeq) :+
SESSION_CATALOG_NAME).distinct.sorted
+ val allCatalogs = (catalogs.keys.toSeq :+
SESSION_CATALOG_NAME).distinct.sorted
Review Comment:
We should use
```
synchronized(catalogs) {
catalogs.keys.toSeq
}
```
if the accesses of catalogs should be synchronized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
