HyukjinKwon commented on code in PR #44940:
URL: https://github.com/apache/spark/pull/44940#discussion_r1470428827
##########
bin/pyspark:
##########
@@ -48,6 +48,35 @@ export PYSPARK_PYTHON
export PYSPARK_DRIVER_PYTHON
export PYSPARK_DRIVER_PYTHON_OPTS
+# Attempt to find JAVA_HOME.
+# If JAVA_HOME not set, install JDK 17 and set JAVA_HOME using a temp dir, and
adding the
+# temp dir to the PYTHONPATH.
+if [ -n "${JAVA_HOME}" ]; then
+ RUNNER="${JAVA_HOME}/bin/java"
+else
+ if [ "$(command -v java)" ]; then
+ RUNNER="java"
+ else
+ echo -n "JAVA_HOME is not set. Would you like to install JDK 17 and set
JAVA_HOME? (Y/N) " >&2
+
+ read -r input
+
+ if [[ "${input,,}" == "y" ]]; then
+ TEMP_DIR=$(mktemp -d)
+ $PYSPARK_DRIVER_PYTHON -m pip install --target="$TEMP_DIR" install-jdk
+ export JAVA_HOME=$(PYTHONPATH="$TEMP_DIR" $PYSPARK_DRIVER_PYTHON -c
'import jdk; print(jdk.install("17"))')
+ RUNNER="${JAVA_HOME}/bin/java"
+ echo "JDK was installed to the path \"$JAVA_HOME\""
+ echo "You can avoid needing to re-install JDK by setting your
JAVA_HOME environment variable"\
+ "to \"$JAVA_HOME\""
+ else
+ echo "JDK installation skipped."\
+ "You can manually install JDK (17 or later) and set JAVA_HOME in your
environment."
Review Comment:
```suggestion
echo "JDK installation skipped. You can manually install JDK (17 or
later) and set JAVA_HOME in your environment."
```
##########
bin/pyspark:
##########
@@ -48,6 +48,35 @@ export PYSPARK_PYTHON
export PYSPARK_DRIVER_PYTHON
export PYSPARK_DRIVER_PYTHON_OPTS
+# Attempt to find JAVA_HOME.
+# If JAVA_HOME not set, install JDK 17 and set JAVA_HOME using a temp dir, and
adding the
+# temp dir to the PYTHONPATH.
+if [ -n "${JAVA_HOME}" ]; then
+ RUNNER="${JAVA_HOME}/bin/java"
+else
+ if [ "$(command -v java)" ]; then
+ RUNNER="java"
+ else
+ echo -n "JAVA_HOME is not set. Would you like to install JDK 17 and set
JAVA_HOME? (Y/N) " >&2
+
+ read -r input
+
+ if [[ "${input,,}" == "y" ]]; then
+ TEMP_DIR=$(mktemp -d)
+ $PYSPARK_DRIVER_PYTHON -m pip install --target="$TEMP_DIR" install-jdk
+ export JAVA_HOME=$(PYTHONPATH="$TEMP_DIR" $PYSPARK_DRIVER_PYTHON -c
'import jdk; print(jdk.install("17"))')
+ RUNNER="${JAVA_HOME}/bin/java"
+ echo "JDK was installed to the path \"$JAVA_HOME\""
+ echo "You can avoid needing to re-install JDK by setting your
JAVA_HOME environment variable"\
+ "to \"$JAVA_HOME\""
Review Comment:
```suggestion
echo "You can avoid needing to re-install JDK by setting your
JAVA_HOME environment variable to \"$JAVA_HOME\""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
