srielau commented on code in PR #44938:
URL: https://github.com/apache/spark/pull/44938#discussion_r1473759727
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -1534,6 +1534,9 @@ class Analyzer(override val catalogManager:
CatalogManager) extends RuleExecutor
// If the projection list contains Stars, expand it.
case p: Project if containsStar(p.projectList) =>
p.copy(projectList = buildExpandedProjectList(p.projectList, p.child))
+ // If the filter list contains Stars, expand it.
Review Comment:
Define all. I don't think it's useful fro GROUP BY (ALL is better), and
semantic is not clear (or dangerous) for ORDER BY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
