cloud-fan commented on code in PR #39754:
URL: https://github.com/apache/spark/pull/39754#discussion_r1473829097


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -302,6 +308,16 @@ trait CheckAnalysis extends PredicateHelper with 
LookupCatalog with QueryErrorsB
         // general unresolved check below to throw a more tailored error 
message.
         new 
ResolveReferencesInAggregate(catalogManager).checkUnresolvedGroupByAll(operator)
 
+        getAllExpressions(operator).foreach(_.foreach {
+          case se: ScopedExpression if !se.resolved =>

Review Comment:
   can we also fail if `ScopedExpression` is still present? I think the 
analyzer should have removed it if its child is resolved, but just in case if 
bugs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to