cloud-fan commented on code in PR #44968:
URL: https://github.com/apache/spark/pull/44968#discussion_r1474560878
##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##########
@@ -1388,28 +1388,43 @@ public UTF8String copy() {
return fromBytes(bytes);
}
+ /**
+ * Collation aware comparison between two UTF8 strings.
Review Comment:
Can we delay this change? I have not made my mind yet and I still feel
awkward putting a "flag" in `UTF8String` to control the behavior of its APIs.
It's probably better to keep UTF8String a pure data class and we create
different comparators/hashers w.r.t. the collation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
