nastra commented on code in PR #44970:
URL: https://github.com/apache/spark/pull/44970#discussion_r1474583715
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ViewCatalog.java:
##########
@@ -129,10 +129,11 @@ default boolean viewExists(Identifier ident) {
*
* @param viewInfo the info class holding all view information
* @param orCreate create the view if it doesn't exist
+ * @return the created/replaced created
Review Comment:
@cloud-fan do you mean adding `This can be null if getting the metadata for
the view is expensive` to the javadoc? Sure I can do that, but the default
implementation currently would always return the created view
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
