jingz-db commented on code in PR #44961:
URL: https://github.com/apache/spark/pull/44961#discussion_r1475378218


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala:
##########
@@ -201,6 +205,15 @@ private[sql] class HDFSBackedStateStoreProvider extends 
StateStoreProvider with
     override def toString(): String = {
       
s"HDFSStateStore[id=(op=${id.operatorId},part=${id.partitionId}),dir=$baseDir]"
     }
+
+    override def valuesIterator(key: UnsafeRow, colFamilyName: String): 
Iterator[UnsafeRow] = {

Review Comment:
   I maybe miss something. Is there any consideration of not throwing error for 
`valuesIterator` in `HDFSBackedReadStateStore` and throws error here in 
`HDFSBackedStateStore`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to