mkaravel opened a new pull request, #44995:
URL: https://github.com/apache/spark/pull/44995

   
   ### What changes were proposed in this pull request?
   
   The current signature of the `hllInvalidLgK` query execution error takes 
four arguments:
   1. The SQL function (a string).
   2. The minimum possible `lgk` value (an integer).
   3. The maximum possible `lgk` value (an integer).
   4. The actual invalid `lgk` value (a string).
   
   There is no meaningful reason for the 4th argument to be a string. In this 
PR we change it to be an integer, just like the minimum and maximum valid 
values.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Seeking to make the signature of the `hllInvalidLgK` more meaningful and 
self-consistent.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, there is no user-facing changes because of this PR. This is just an 
internal change.
   
   ### How was this patch tested?
   
   Existing tests suffice.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to