MaxGekk commented on code in PR #44968:
URL: https://github.com/apache/spark/pull/44968#discussion_r1475711921
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -451,6 +451,12 @@
],
"sqlState" : "42704"
},
+ "COLLATION_INVALID_NAME" : {
+ "message" : [
+ "The value <collationName> does not represent correct collation name."
+ ],
+ "sqlState" : "22018"
Review Comment:
Could you elaborate a little bit why did you chose the state:
```json
"22018": {
"description": "invalid character value for cast",
"origin": "SQL/Foundation",
"standard": "Y",
"usedBy": ["SQL/Foundation", "PostgreSQL", "DB2", "Redshift",
"Oracle", "SQL Server"]
},
```
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -451,6 +451,12 @@
],
"sqlState" : "42704"
},
+ "COLLATION_INVALID_NAME" : {
+ "message" : [
+ "The value <collationName> does not represent correct collation name."
Review Comment:
Could we propose some correct collation names that are similar to
`collationName`? See for example:
https://github.com/apache/spark/blob/a3432428e760fc16610cfe3380d3bdea7654f75d/sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala#L109
or
https://github.com/apache/spark/blob/a3432428e760fc16610cfe3380d3bdea7654f75d/sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala#L319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
