09306677806 commented on PR #44991: URL: https://github.com/apache/spark/pull/44991#issuecomment-1923338137
Anyone who wants to do something should charge the wallet that I send to be approved .bc1q2tk3c4z7zvjxhswrdpqt7xp98ea99h29zu9qyh در تاریخ جمعه ۲ فوریه ۲۰۲۴، ۱۲:۰۸ Kent Yao ***@***.***> نوشت: > ***@***.**** commented on this pull request. > ------------------------------ > > In > sql/core/src/test/scala/org/apache/spark/sql/ResolveDefaultColumnsSuite.scala > <https://github.com/apache/spark/pull/44991#discussion_r1475730635>: > > > @@ -213,4 +214,29 @@ class ResolveDefaultColumnsSuite extends QueryTest with SharedSparkSession { > } > } > } > + > + test("SPARK-46949: DDL with valid default char/varchar values") { > + withTable("t") { > + val ddl = > + s""" > + |CREATE TABLE t( > + | key int, > + | v VARCHAR(6) DEFAULT 'apache', > + | c CHAR(5) DEFAULT 'spark') > > For safety reasons, I added a new test at L245. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/44991#discussion_r1475730635>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ANEZZRENIRH6DPBZH32TRHTYRSQX3AVCNFSM6AAAAABCV6HSMSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJYGY3DSMJXHE> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
