cloud-fan commented on code in PR #45000:
URL: https://github.com/apache/spark/pull/45000#discussion_r1475971219
##########
sql/core/src/test/scala/org/apache/spark/sql/ResolveDefaultColumnsSuite.scala:
##########
@@ -256,4 +256,11 @@ class ResolveDefaultColumnsSuite extends QueryTest with
SharedSparkSession {
checkAnswer(sql("select * from t"), Row(1, "apache", "spark "))
}
}
+
+ test("SPARK-46958: Fix bug when canUpcast and result non-foldable
expression") {
+ sql(s"CREATE TABLE t(key int, c STRING DEFAULT date '2018-11-17') " +
Review Comment:
does it work if the default expression is `CAST(date '2018-11-17' AS
STRING)`? I think we should find the root cause and understand why the casted
expression was considered as non-foldable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
