beliefer commented on code in PR #45040:
URL: https://github.com/apache/spark/pull/45040#discussion_r1479487775


##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##########
@@ -446,13 +446,8 @@ private[hive] class HiveClientImpl(
   private def convertHiveTableToCatalogTable(h: HiveTable): CatalogTable = {
     // Note: Hive separates partition columns and the schema, but for us the
     // partition columns are part of the schema
-    val (cols, partCols) = try {
-      (h.getCols.asScala.map(fromHiveColumn), 
h.getPartCols.asScala.map(fromHiveColumn))
-    } catch {
-      case ex: SparkException =>
-        throw QueryExecutionErrors.convertHiveTableToCatalogTableError(
-          ex, h.getDbName, h.getTableName)
-    }

Review Comment:
   Seems good to me. But I don't know the background suppressed the error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to