tigrulya-exe commented on PR #43463: URL: https://github.com/apache/spark/pull/43463#issuecomment-1929611462
@cloud-fan we construct absolute file paths with `har://` scheme in the [DataSourceSuite#buildFullHarPaths](https://github.com/apache/spark/blob/a005f6526eaf212cb5b60b500006d67375103709/sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceSuite.scala#L252) method and then check that they're correctly qualified. Then we [test](https://github.com/apache/spark/blob/a005f6526eaf212cb5b60b500006d67375103709/sql/core/src/test/scala/org/apache/spark/sql/test/DataFrameReaderWriterSuite.scala#L1367) reading files inside har archive by their absolute paths. We don't need to create or test `HarFileSystem` itself, it is extracted from path in the [DataSource#checkAndGlobPathIfNecessary](https://github.com/apache/spark/blob/a005f6526eaf212cb5b60b500006d67375103709/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala#L762) method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
