sahnib commented on code in PR #44961: URL: https://github.com/apache/spark/pull/44961#discussion_r1480294234
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala: ########## @@ -117,6 +118,7 @@ class RocksDB( dbOptions.setTableFormatConfig(tableFormatConfig) dbOptions.setMaxOpenFiles(conf.maxOpenFiles) dbOptions.setAllowFAllocate(conf.allowFAllocate) + dbOptions.setMergeOperator(new StringAppendOperator()) Review Comment: yes, its safe. One aspect is that values will be encoded with a extra int64 value containing the len of actual UnsafeRow bytes. We can avoid it in future by refactoring RocksDBStateEncoder into separate encoders for Key and Value respectively. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
