nchammas commented on code in PR #45036:
URL: https://github.com/apache/spark/pull/45036#discussion_r1482089432
##########
core/src/test/scala/org/apache/spark/util/collection/OpenHashSetSuite.scala:
##########
@@ -269,4 +269,35 @@ class OpenHashSetSuite extends SparkFunSuite with Matchers
{
assert(pos1 == pos2)
}
}
+
+ test("SPARK-45599: 0.0 and -0.0 are equal but not the same") {
Review Comment:
> In Spark, 0.0 == -0.0, and in GROUP BY, 0.0 and -0.0 are considered to be
in the same group and normalized to 0.0.
This PR does not change this behavior. I noticed, however, that we do not
have any tests currently to check that -0.0 is normalized and grouped as you
describe, so I went ahead and added such a test in
2bfc60548db2c41f4c64b63d40a2652cb22732ab.
Does this address your concern? Or are you suggesting that we should
normalize -0.0 to 0.0 across the board?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
