rbri commented on code in PR #45079:
URL: https://github.com/apache/spark/pull/45079#discussion_r1485042077
##########
pom.xml:
##########
@@ -710,19 +710,19 @@
</dependency>
<dependency>
<groupId>org.seleniumhq.selenium</groupId>
- <artifactId>htmlunit-driver</artifactId>
- <version>${htmlunit-driver.version}</version>
+ <artifactId>htmlunit3-driver</artifactId>
+ <version>${htmlunit3-driver.version}</version>
<scope>test</scope>
</dependency>
<!-- Update htmlunit dependency that selenium uses for better JS support
-->
<dependency>
- <groupId>net.sourceforge.htmlunit</groupId>
+ <groupId>org.htmlunit</groupId>
<artifactId>htmlunit</artifactId>
<version>${htmlunit.version}</version>
<scope>test</scope>
</dependency>
<dependency>
- <groupId>net.sourceforge.htmlunit</groupId>
+ <groupId>org.htmlunit</groupId>
<artifactId>htmlunit-core-js</artifactId>
<version>${htmlunit.version}</version>
<scope>test</scope>
Review Comment:
the xml-apis dependency is no longer required by html unit and can go away -
removing this solves also some CVE warnings
##########
pom.xml:
##########
@@ -710,19 +710,19 @@
</dependency>
<dependency>
<groupId>org.seleniumhq.selenium</groupId>
- <artifactId>htmlunit-driver</artifactId>
- <version>${htmlunit-driver.version}</version>
+ <artifactId>htmlunit3-driver</artifactId>
+ <version>${htmlunit3-driver.version}</version>
<scope>test</scope>
</dependency>
<!-- Update htmlunit dependency that selenium uses for better JS support
-->
<dependency>
Review Comment:
this can be removed as it is a dependency of the htmlunit3-driver
##########
pom.xml:
##########
@@ -710,19 +710,19 @@
</dependency>
<dependency>
Review Comment:
I think this is the only dependency you need
##########
pom.xml:
##########
@@ -710,19 +710,19 @@
</dependency>
<dependency>
<groupId>org.seleniumhq.selenium</groupId>
- <artifactId>htmlunit-driver</artifactId>
- <version>${htmlunit-driver.version}</version>
+ <artifactId>htmlunit3-driver</artifactId>
+ <version>${htmlunit3-driver.version}</version>
<scope>test</scope>
</dependency>
<!-- Update htmlunit dependency that selenium uses for better JS support
-->
<dependency>
- <groupId>net.sourceforge.htmlunit</groupId>
+ <groupId>org.htmlunit</groupId>
<artifactId>htmlunit</artifactId>
<version>${htmlunit.version}</version>
<scope>test</scope>
</dependency>
<dependency>
- <groupId>net.sourceforge.htmlunit</groupId>
Review Comment:
this can be removed as it is a dependency of the htmlunit3-driver
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
