nchammas opened a new pull request, #45083:
URL: https://github.com/apache/spark/pull/45083
### What changes were proposed in this pull request?
Instead of posting allllllllll of the expected test output, just show the
path to the test file and the number of blocks.
### Why are the changes needed?
Compare the current behavior when an SQL test fails:
```
[info] - group-by.sql *** FAILED *** (2 seconds, 92 milliseconds)
[info] group-by.sql
[info] Array("-- Automatically generated by SQLQueryTestSuite
[info] ", "CREATE OR REPLACE TEMPORARY VIEW testData AS SELECT * FROM
VALUES
[info] (1, 1), (1, 2), (2, 1), (2, 2), (3, 1), (3, 2), (null, 1), (3,
null), (null, null)
[hundreds and hundreds of lines of SQL test output snipped]
[info] 0.0 2
[info] Infinity 2
[info] NaN 2
[info] ") had size 259 instead of expected size 262 Expected 262 blocks in
result file but got 259. Try regenerate the result files.
(SQLQueryTestSuite.scala:625)
```
To the behavior after this patch:
```
[info] - group-by.sql *** FAILED *** (2 seconds, 10 milliseconds)
[info] group-by.sql
[info] Expected 262, but got 259 blocks in result file
'.../spark/sql/core/src/test/resources/sql-tests/results/group-by.sql.out'. Try
regenerating the result files. (SQLQueryTestSuite.scala:627)
```
Maybe I am missing something, but I don't think it helps anyone to see the
whole test output file when the only things that are relevant are the file name
and number of blocks.
Note also how the current error message on `master` repeats the expected and
actual number of blocks.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
I ran some SQL tests from the sbt console:
```
~sql/testOnly org.apache.spark.sql.SQLQueryTestSuite -- -z "group-by"
```
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
