HeartSaVioR commented on code in PR #45038:
URL: https://github.com/apache/spark/pull/45038#discussion_r1487149178
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ValueStateImpl.scala:
##########
@@ -52,14 +58,12 @@ class ValueStateImpl[S](
val keyByteArr = toRow
.apply(keyOption.get).asInstanceOf[UnsafeRow].getBytes()
- val schemaForKeyRow: StructType = new StructType().add("key", BinaryType)
val keyEncoder = UnsafeProjection.create(schemaForKeyRow)
Review Comment:
This seems to be missing spot on previous PR review - we need to do this
only once instead of each method call. Please move to the field of class. Same
for valueEncoder for encodeValue as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
